Skip to content

[ENHANCEMENT] WIP: Animation Priority system #5123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

[ENHANCEMENT] WIP: Animation Priority system #5123

wants to merge 6 commits into from
+53 −63

Conversation

AbnormalPoof
Copy link
Collaborator

@AbnormalPoof AbnormalPoof commented May 21, 2025 •
edited
Loading

Linked Issues

Fixes #3491, fixes #2367 (for real this time).

Description

This PR adds a new animation priority system, replacing ignoreExclusionPref.
priority acts like zIndex for characters, where the higher the value is, the higher the animation is prioritized!

TODO

  • Animate Atlas character support
  • Stage prop support
  • Default priorities for sing and idle/dance
  • Set priorities for existing animations
  • Figure out how to do forced animations

@AbnormalPoof AbnormalPoof added the type: enhancement Involves an enhancement or new feature. label May 21, 2025
@github-actions github-actions bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. labels May 21, 2025
@AbnormalPoof AbnormalPoof added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels May 21, 2025
@Lasercar Lasercar mentioned this pull request May 21, 2025
Closed
CrusherNotDrip
CrusherNotDrip approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@CrusherNotDrip CrusherNotDrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought of this idea like a year ago for an engine I was working on, just never thought of adding it to base game.

@Lasercar
Copy link
Contributor

I thought of this idea like a year ago for an engine I was working on, just never thought of adding it to base game.

You approved the PR... even though it's still a draft...?

@CrusherNotDrip
Copy link
Contributor

You approved the PR... even though it's still a draft...?

i can always approve of it again (i wasnt thinking straight)

@github-actions github-actions bot added size: large A large pull request with more than 100 changes. and removed size: medium A medium pull request with 100 or fewer changes. labels May 24, 2025
AbnormalPoof
AbnormalPoof commented May 25, 2025
View reviewed changes
source/funkin/play/stage/Stage.hx
var propSprite:StageProp;
if (dataProp.danceEvery != 0)
{
propSprite = new Bopper(dataProp.danceEvery);
}
else
{
propSprite = new StageProp();
}
var propSprite:Bopper = new Bopper(dataProp.danceEvery);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll figure something else this is a temporary solution for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrusherNotDrip CrusherNotDrip CrusherNotDrip approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: needs revision Cannot be approved because it is awaiting some work by the contributor. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbnormalPoof @Lasercar @CrusherNotDrip